fix: prevent event propagation issues in sidebar and editor
- Add type=button to Cancel/Save buttons in editor to prevent form submission - Add href=# and return false to quick-links to prevent default anchor behavior - StopPropagation was already present in sidebar handlers (verified) - Document view buttons already had type=button (verified) These fixes ensure: - Library/tag clicks don't bubble up and trigger wrong handlers - Quick-link buttons don't cause unexpected navigation - Editor buttons don't accidentally submit forms
This commit is contained in:
@@ -58,8 +58,8 @@ export function renderSidebar({ libraries, tags, selectedLibrary, selectedTag, o
|
||||
</div>
|
||||
<div class="quick-links">
|
||||
<a class="quick-link" data-action="home">📋 All Documents</a>
|
||||
<a class="quick-link" onclick="window.showNewDocModal()">📄 New Document</a>
|
||||
<a class="quick-link" onclick="window.showNewLibraryModal()">📁 New Library</a>
|
||||
<a class="quick-link" href="#" onclick="window.showNewDocModal(); return false;">📄 New Document</a>
|
||||
<a class="quick-link" href="#" onclick="window.showNewLibraryModal(); return false;">📁 New Library</a>
|
||||
</div>
|
||||
</div>
|
||||
</aside>
|
||||
|
||||
@@ -41,9 +41,9 @@ export async function renderEditor(app) {
|
||||
function render() {
|
||||
appEl.innerHTML = `
|
||||
<header class="app-header">
|
||||
<button class="btn btn-ghost" onclick="handleCancel()">Cancel</button>
|
||||
<button type="button" class="btn btn-ghost" onclick="handleCancel()">Cancel</button>
|
||||
<span style="flex:1;margin-left:16px">${isNew ? 'New Document' : 'Editing: ' + escapeHtml(formData.title)}</span>
|
||||
<button class="btn btn-primary" onclick="handleSave()">Save</button>
|
||||
<button type="button" class="btn btn-primary" onclick="handleSave()">Save</button>
|
||||
</header>
|
||||
<main class="main-content">
|
||||
<div class="editor-container">
|
||||
|
||||
Reference in New Issue
Block a user