From d7bb018c83a34364bdeb46691f462392aef0b356 Mon Sep 17 00:00:00 2001
From: Hiro <hiro@openclaw.ai>
Date: Sat, 28 Mar 2026 12:45:22 +0000
Subject: [PATCH] fix: prevent event propagation issues in sidebar and editor

- Add type=button to Cancel/Save buttons in editor to prevent form submission
- Add href=# and return false to quick-links to prevent default anchor behavior
- StopPropagation was already present in sidebar handlers (verified)
- Document view buttons already had type=button (verified)

These fixes ensure:
- Library/tag clicks don't bubble up and trigger wrong handlers
- Quick-link buttons don't cause unexpected navigation
- Editor buttons don't accidentally submit forms
---
 public/js/components/sidebar.js | 4 ++--
 public/js/views/editor.js       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/public/js/components/sidebar.js b/public/js/components/sidebar.js
index e7905f4..ea5cfbf 100644
--- a/public/js/components/sidebar.js
+++ b/public/js/components/sidebar.js
@@ -58,8 +58,8 @@ export function renderSidebar({ libraries, tags, selectedLibrary, selectedTag, o
         </div>
         <div class="quick-links">
           <a class="quick-link" data-action="home">📋 All Documents</a>
-          <a class="quick-link" onclick="window.showNewDocModal()">📄 New Document</a>
-          <a class="quick-link" onclick="window.showNewLibraryModal()">📁 New Library</a>
+          <a class="quick-link" href="#" onclick="window.showNewDocModal(); return false;">📄 New Document</a>
+          <a class="quick-link" href="#" onclick="window.showNewLibraryModal(); return false;">📁 New Library</a>
         </div>
       </div>
     </aside>
diff --git a/public/js/views/editor.js b/public/js/views/editor.js
index 442bb34..06e4baa 100644
--- a/public/js/views/editor.js
+++ b/public/js/views/editor.js
@@ -41,9 +41,9 @@ export async function renderEditor(app) {
   function render() {
     appEl.innerHTML = `
       <header class="app-header">
-        <button class="btn btn-ghost" onclick="handleCancel()">Cancel</button>
+        <button type="button" class="btn btn-ghost" onclick="handleCancel()">Cancel</button>
         <span style="flex:1;margin-left:16px">${isNew ? 'New Document' : 'Editing: ' + escapeHtml(formData.title)}</span>
-        <button class="btn btn-primary" onclick="handleSave()">Save</button>
+        <button type="button" class="btn btn-primary" onclick="handleSave()">Save</button>
       </header>
       <main class="main-content">
         <div class="editor-container">