Allow remote-to-remote sync pairs

This commit is contained in:
2026-07-17 18:26:19 -04:00
parent 0437a7b248
commit 743882eb0e
2 changed files with 18 additions and 4 deletions
+4 -4
View File
@@ -75,8 +75,8 @@ func (h *SyncPairHandler) Create(w http.ResponseWriter, r *http.Request) {
writeError(w, http.StatusBadRequest, "direction must be push, pull, or mirror") writeError(w, http.StatusBadRequest, "direction must be push, pull, or mirror")
return return
} }
if req.SourceMachineID != nil && req.DestMachineID != nil { if req.SourceMachineID != nil && req.DestMachineID != nil && *req.SourceMachineID == *req.DestMachineID {
writeError(w, http.StatusBadRequest, "both source and destination cannot be remote machines; one side must be the server (set one MachineID to null)") writeError(w, http.StatusBadRequest, "source and destination cannot be the same machine")
return return
} }
if req.RsyncFlags == "" { if req.RsyncFlags == "" {
@@ -131,8 +131,8 @@ func (h *SyncPairHandler) Update(w http.ResponseWriter, r *http.Request) {
writeError(w, http.StatusBadRequest, "direction must be push, pull, or mirror") writeError(w, http.StatusBadRequest, "direction must be push, pull, or mirror")
return return
} }
if req.SourceMachineID != nil && req.DestMachineID != nil { if req.SourceMachineID != nil && req.DestMachineID != nil && *req.SourceMachineID == *req.DestMachineID {
writeError(w, http.StatusBadRequest, "both source and destination cannot be remote machines; one side must be the server (set one MachineID to null)") writeError(w, http.StatusBadRequest, "source and destination cannot be the same machine")
return return
} }
+14
View File
@@ -111,6 +111,14 @@ export default function SyncPairs() {
toast.error('Source and destination paths are required'); toast.error('Source and destination paths are required');
return; return;
} }
if (
form.source_machine_id !== null &&
form.dest_machine_id !== null &&
form.source_machine_id === form.dest_machine_id
) {
toast.error('Source and destination cannot be the same machine');
return;
}
setLoading(true); setLoading(true);
try { try {
await api(form.id ? `/api/sync-pairs/${form.id}` : '/api/sync-pairs', { await api(form.id ? `/api/sync-pairs/${form.id}` : '/api/sync-pairs', {
@@ -325,6 +333,9 @@ export default function SyncPairs() {
))} ))}
</SelectContent> </SelectContent>
</Select> </Select>
<p className="text-xs text-fg-subtle">
Where the data lives. Pick <span className="font-medium">Local server</span> if it&apos;s on this machine, otherwise the remote machine holding the data.
</p>
</div> </div>
<div className="space-y-1.5"> <div className="space-y-1.5">
<Label htmlFor="sp-dest-machine">Dest Machine</Label> <Label htmlFor="sp-dest-machine">Dest Machine</Label>
@@ -346,6 +357,9 @@ export default function SyncPairs() {
))} ))}
</SelectContent> </SelectContent>
</Select> </Select>
<p className="text-xs text-fg-subtle">
Where to copy the data. Can be the same machine (no-op) or any remote. Remote-to-remote is supported.
</p>
</div> </div>
</div> </div>
<div className="grid grid-cols-2 gap-3"> <div className="grid grid-cols-2 gap-3">