From fb5ae6ceb5686bc0e916762472d4d0182700aa89 Mon Sep 17 00:00:00 2001
From: Daniel Arroyo <darroylat@gmail.com>
Date: Thu, 30 Jul 2026 18:14:51 -0400
Subject: [PATCH] Fix staticcheck SA4000 in TestDurationHelpers

Compare against expected values (300s, 20s, 5s) instead of self-comparison
---
 internal/config/config_test.go | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/internal/config/config_test.go b/internal/config/config_test.go
index de0c719..58271cb 100644
--- a/internal/config/config_test.go
+++ b/internal/config/config_test.go
@@ -3,6 +3,7 @@ package config
 import (
 	"os"
 	"testing"
+	"time"
 )
 
 func TestLoad(t *testing.T) {
@@ -57,18 +58,20 @@ func TestLlamaServerURL(t *testing.T) {
 }
 
 func TestDurationHelpers(t *testing.T) {
+	t.Setenv("LLAMA_SERVER_STARTUP_TIMEOUT", "300")
+	t.Setenv("LLAMA_SERVER_STOP_TIMEOUT", "20")
+	t.Setenv("MODEL_SWAP_COOLDOWN", "5")
+
 	cfg := Load()
 
-	if cfg.LlamaServerStartupTimeoutDuration() != cfg.LlamaServerStartupTimeoutDuration() {
-		t.Error("startup timeout duration mismatch")
+	if got := cfg.LlamaServerStartupTimeoutDuration(); got != 300*time.Second {
+		t.Errorf("startup: got %v, want 300s", got)
 	}
-
-	if cfg.LlamaServerStopTimeoutDuration() != cfg.LlamaServerStopTimeoutDuration() {
-		t.Error("stop timeout duration mismatch")
+	if got := cfg.LlamaServerStopTimeoutDuration(); got != 20*time.Second {
+		t.Errorf("stop: got %v, want 20s", got)
 	}
-
-	if cfg.ModelSwapCooldownDuration() != cfg.ModelSwapCooldownDuration() {
-		t.Error("model swap cooldown duration mismatch")
+	if got := cfg.ModelSwapCooldownDuration(); got != 5*time.Second {
+		t.Errorf("cooldown: got %v, want 5s", got)
 	}
 }