From 4d2a873c8bc3630d9f4f2d045055fd09d73f7e96 Mon Sep 17 00:00:00 2001 From: Daniel Arroyo Date: Mon, 6 Jul 2026 00:33:56 -0400 Subject: [PATCH] fix: remove SetVersionInfo call that overwrote ldflag-injected version The web.Version/web.Commit were being reset to 'dev' at runtime because SetVersionInfo was called with the (unused) local vars. Now ldflags-injected values are used directly without override. Version bump: 0.2.0 -> 0.2.1 --- cmd/nasctl/main.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/cmd/nasctl/main.go b/cmd/nasctl/main.go index e692a14..6759c1b 100644 --- a/cmd/nasctl/main.go +++ b/cmd/nasctl/main.go @@ -17,11 +17,6 @@ import ( "github.com/darroyo/nasctl/internal/web" ) -var ( - version = "dev" - commit = "" -) - func main() { addr := flag.String("addr", envOrDefault("NASCTL_ADDR", ":8080"), "HTTP listen address") dbPath := flag.String("db", envOrDefault("NASCTL_DB", "/var/lib/nasctl/nasctl.db"), "SQLite database path") @@ -84,7 +79,6 @@ func main() { }) eng := engine.New(sambaModule, nfsModule, usersModule) - web.SetVersionInfo(version, commit) srv := web.NewServer(database, eng, web.Options{ AllowedRoots: parseRoots(*allowedRoots), Auth: auth, @@ -92,7 +86,7 @@ func main() { ExportsPath: *exportsPath, }) - log.Printf("nasctl %s (commit %s) listening on %s (db=%s exec-system=%v)", version, commit, *addr, *dbPath, *execSystem) + log.Printf("nasctl %s (commit %s) listening on %s (db=%s exec-system=%v)", web.Version, web.Commit, *addr, *dbPath, *execSystem) if err := http.ListenAndServe(*addr, srv.Handler()); err != nil { log.Fatalf("server error: %v", err) }